Include query string in URL for ASGI/WSGI requests#622
Open
bitterpanda63 wants to merge 1 commit intomainfrom
Open
Include query string in URL for ASGI/WSGI requests#622bitterpanda63 wants to merge 1 commit intomainfrom
bitterpanda63 wants to merge 1 commit intomainfrom
Conversation
The request URL captured for attack events was missing the query string, causing path-traversal events (and other query-driven attacks) to lose the malicious payload from their reported URL. Re-enables test_path_traversal in the QA suite.
This was referenced Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
?path=...payloads, etc.) lost the malicious payload from their reported URL.build_url_from_asgi) and WSGI (build_url_from_wsgi) URL builders to append?<query_string>when present.Re-enables
test_path_traversalin the QA suite. Also lays the groundwork for #fix-wave-attack — wave-attack samples are keyed oncontext.url, so without the query string 16 distinct?path=q1..q16requests collapsed into a single sample.Test plan
aikido_zen/context/asgi/build_url_from_asgi_test.py— added query-string test cases (including the path-traversal scenario).aikido_zen/context/wsgi/build_url_from_wsgi_test.py— added query-string test cases.make testminus network-dependent tests).test_path_traversalpasses once merged.🤖 Generated with Claude Code
Summary by Aikido
⚡ Enhancements
🐛 Bugfixes
More info